[SCC-4425] Trim whitespace on call number search#438
Merged
yossariano merged 2 commits intomainfrom Jan 22, 2025
Merged
Conversation
nonword
approved these changes
Jan 15, 2025
charmingduchess
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping things light for my first PR- let me know if there's some part of the process that I'm missing or doing incorrectly!
Ticket
https://newyorkpubliclibrary.atlassian.net/browse/SCC-4425
Testing
Tested in my local server. Before, querying by call number with a leading space (i.e. like so) would return 0 results. After adding this
trim()any leading / trailing whitespace is ignored and we get results.